fix"convert --images" output to right format#9904
Merged
Conversation
laurazard
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
milas
suggested changes
Oct 19, 2022
Contributor
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
Thanks for the PR - good catch!
Left a comment re: the separator, as there is a global for this that gets set based on whether Compose is running in compatibility mode or not.
Contributor
|
Thanks for making the change - unfortunately, the new commit is missing DCO sign-off so isn't passing CI. Rebase instructions @ https://github.com/docker/compose/pull/9904/checks?check_run_id=9738031634 |
ndeloof
reviewed
Nov 29, 2022
cmd/compose/convert.go
Outdated
| fmt.Println(s.Image) | ||
| } else { | ||
| fmt.Printf("%s_%s\n", project.Name, s.Name) | ||
| fmt.Printf("%s\n", project.Name+api.Separator+s.Name) |
Contributor
There was a problem hiding this comment.
as we already rely on Printf, better not use + to append strings
ndeloof
approved these changes
Nov 30, 2022
Signed-off-by: windforce17 <wzcboss@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Windforce17 42843391+Windforce17@users.noreply.github.com
What I did
According to docker images name rule: https://docs.docker.com/engine/reference/commandline/tag/#description
docker compose convert --imagesshould not contain underscores.closes #9920