Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of deploy.reservation.memory #9947

Merged
merged 1 commit into from Nov 2, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 24, 2022

Signed-off-by: Guillaume Lours 705411+glours@users.noreply.github.com

What I did
Add support of deploy.reservation.memory

Related issue
fixes #9902

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours requested a review from a team October 24, 2022 14:09
@glours glours self-assigned this Oct 24, 2022
@glours glours requested review from nicksieger, ndeloof, StefanScherer, ulyssessouza, milas and laurazard and removed request for a team October 24, 2022 14:09
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the manage-resources-reservations branch from 4256968 to 7ba9aac Compare October 24, 2022 20:52
@codecov-commenter
Copy link

Codecov Report

Base: 75.86% // Head: 75.86% // No change to project coverage 👍

Coverage data is based on head (7ba9aac) compared to base (6d64242).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #9947   +/-   ##
=======================================
  Coverage   75.86%   75.86%           
=======================================
  Files           2        2           
  Lines         232      232           
=======================================
  Hits          176      176           
  Misses         49       49           
  Partials        7        7           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurazard laurazard merged commit df9e605 into docker:v2 Nov 2, 2022
@glours glours deleted the manage-resources-reservations branch January 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory reservations have no effect
4 participants