Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't package runc for RHEL/CentOS >= 8 #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't package runc for RHEL/CentOS >= 8 #272

wants to merge 1 commit into from
+14 −1

Conversation

Romain-Geissler-1A
Copy link
Contributor

Contains 2 commits. The first one is the commit adding CentOS 9 which I expect you will merge soon (#270).

The second commit is largely inspired by what @goeranu wrote in #231 and is the real purpose of this pull request: stop packaging runc for RHEL/CentOS >= 8, as Red Hat already packages it and it conflicts with the existing containerd.io packages.

@Romain-Geissler-1A Romain-Geissler-1A changed the title Dont package runc for rhel Don't package runc for RHEL/CentOS >= 8 Mar 9, 2022
@Romain-Geissler-1A Romain-Geissler-1A mentioned this pull request Mar 9, 2022
Closed
@Romain-Geissler-1A Romain-Geissler-1A mentioned this pull request Mar 17, 2022
Open
@Romain-Geissler-1A Romain-Geissler-1A force-pushed the dont-package-runc-for-rhel branch 2 times, most recently from 913c7d7 to 94d3f5d Compare May 4, 2022 21:17
@Romain-Geissler-1A
Copy link
Contributor Author

@thaJeztah I have rebased/updated this pull request adopting the style you used in #283.

@Romain-Geissler-1A
Copy link
Contributor Author

Romain-Geissler-1A commented May 5, 2022 •
edited

Arg... again a build failure, and I can't see the logs, so I don't know what's wrong... When I try locally on my x86_64 machine it works for centos 7, 8 and 9, fedora 36 and leap 15. I have not tried other build targets (I tried only make $NAME_OF_BASE_OS_IMAGE).

@rumpl
Copy link
Member

rumpl commented May 5, 2022

It's an unrelated error:

#13 16.99 Fetched 70.4 MB in 7s (10.8 MB/s)

#13 16.99 E: Failed to fetch http://archive.raspbian.org/raspbian/pool/main/libi/libio-html-perl/libio-html-perl_1.001-1_all.deb  Undetermined Error [IP: 93.93.128.191 80]

#13 16.99 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

I restarted the build

@Romain-Geissler-1A
Don't package runc for RHEL/CentOS >= 8
1774abf 
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
This was referenced May 6, 2022
Closed
Closed
@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@Romain-Geissler-1A Romain-Geissler-1A mentioned this pull request May 21, 2022
Open
@Romain-Geissler-1A
Copy link
Contributor Author

Ping

5 similar comments
@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@Romain-Geissler-1A
Copy link
Contributor Author

Ping

@Romain-Geissler-1A
Copy link
Contributor Author

Ping

AkihiroSuda
AkihiroSuda reviewed Aug 16, 2022
View reviewed changes
rpm/containerd.spec
@@ -30,18 +30,22 @@ AutoReq: no

Name: containerd.io
Provides: containerd
# For some reason on rhel >= 8 if we "provide" runc then it makes this package unsearchable
# On RHEL >= 8, runc is packaged by Red Hat so it won't be provided by this package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to generate runc rpm too, to override the Red Hat version?

cc @thaJeztah @kolyshkin WDYT?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make a separate runc package when there already exist a native one? Isn't it better to use the OS version when there is one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OS version is often outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goeranu goeranu goeranu left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Romain-Geissler-1A @rumpl @goeranu @AkihiroSuda