Print error for failed HTTP auth request. #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Leung <kleung@google.com>
|
Code LGTM. @k4leung4 Any tests for this? |
| @@ -240,7 +240,8 @@ func (th *tokenHandler) fetchToken(params map[string]string) (token *tokenRespon | |||
| defer resp.Body.Close() | |||
|
|
|||
| if !client.SuccessStatus(resp.StatusCode) { | |||
| return nil, fmt.Errorf("token auth attempt for registry: %s request failed with status: %d %s", req.URL, resp.StatusCode, http.StatusText(resp.StatusCode)) | |||
| err := client.HandleErrorResponse(resp) | |||
| return nil, fmt.Errorf("token auth attempt for registry: %s request failed with status: %d %s: %q", req.URL, resp.StatusCode, http.StatusText(resp.StatusCode), err) | |||
There was a problem hiding this comment.
Seems odd to throw away a nicely typed error for a formatted string here. Perhaps any additional messaging about failure to fetch a token should be left to the caller.
|
FYI, he's on vacation this week. I will ping him Monday. :) |
|
Thanks @mattmoor |
Signed-off-by: Kenny Leung <kleung@google.com>
…ution into print-error-msg Changed to use typed error instead of formatted string. Added tests for new public method. Signed-off-by: Kenny Leung <kleung@google.com>
|
Changed to make use of typed error instead of formatted string. please take another look. |
Current coverage is
|
|
LGTM |
|
Anything left needed to merge this? I ask in part because of the upcoming code freeze. |
|
LGTM |
|
CI is back, lets turn this green then merge 😉 |
stevvooe
added a commit
that referenced
this pull request
Jan 5, 2016
Print error for failed HTTP auth request.
aaronlehmann
added a commit
to aaronlehmann/distribution
that referenced
this pull request
Jan 20, 2016
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
dalsh
pushed a commit
to dalsh/distribution
that referenced
this pull request
Jan 13, 2017
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
Print error for failed HTTP auth request.
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
Print error for failed HTTP auth request.
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
dylanrhysscott
pushed a commit
to digitalocean/docker-distribution
that referenced
this pull request
Jan 5, 2023
distribution#1249 changed token fetching to parse HTTP error response bodies as serialized errcodes. However, Docker Hub's authentication endpoint does not return error bodies in this format. To work around this, convert its format into ErrCodeUnauthorized or ErrCodeUnknown. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a failed HTTP auth token request, in addition to the current message that is returned, also return the error message in the response. This is to provide the user with a more descriptive message about what went wrong.
Signed-off-by: Kenny Leung kleung@google.com