Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Introduction section of specification #7

Merged
merged 1 commit into from
Jan 2, 2015
Merged

Rewrite Introduction section of specification #7

merged 1 commit into from
Jan 2, 2015

Conversation

stevvooe
Copy link
Collaborator

Signed-off-by: Stephen J Day stephen.day@docker.com

@stevvooe
Copy link
Collaborator Author


> **TODO**: Merge this section into the overview/introduction.
While the V2 registry protocol is usable, there are several problems with the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused by this:

The specification covers the operation of version 2 of this API

And later:

While the V2 registry protocol is usable, there are several problems with the architecture that have led to this new version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see above from the first line, this was originally labeled "V2.1".

We still need some way of clearing the ambiguity about this not being the same as the "V2" API that was originally defined in docker/docker-registry#612

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence should read "While the V1 registry protocol is usable".

@BrianBland
Copy link
Contributor

It won't let me comment on the unchanged part, but we should specify that (bolded the addition) "A component of a repository name must be at least two lowercase alphanumeric characters...".

Additionally, the regular expression can be changed to ^[a-z0-9]+([._-]?[a-z0-9]+)+$, which removes the need for the clarification about 2+ character length.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
@stevvooe
Copy link
Collaborator Author

Additionally, the regular expression can be changed to ^[a-z0-9]+([._-]?[a-z0-9]+)+$, which removes the need for the clarification about 2+ character length.

@BrianBland I've specified this in prose purposely to avoid the confusion we had about regular expressions before.

@dmp42
Copy link
Contributor

dmp42 commented Jan 2, 2015

LGTM

1 similar comment
@icecrime
Copy link

icecrime commented Jan 2, 2015

LGTM

stevvooe added a commit that referenced this pull request Jan 2, 2015
Rewrite Introduction section of specification
@stevvooe stevvooe merged commit cd748f9 into distribution:master Jan 2, 2015
@stevvooe stevvooe deleted the api-specification-introduction branch January 2, 2015 18:47
SteveLasker pushed a commit to SteveLasker/distribution that referenced this pull request Apr 21, 2021
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
sajayantony pushed a commit to sajayantony/distribution that referenced this pull request May 20, 2022
* May 17 live coding

Signed-off-by: Josh Dolitsky <josh@dolit.ski>

* add vendored

Signed-off-by: Josh Dolitsky <josh@dolit.ski>

* prototype of new image spec with Reference support

* update content-type header

Signed-off-by: Akash Singhal <akashsinghal@microsoft.com>

Co-authored-by: Josh Dolitsky <josh@dolit.ski>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants