-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Introduction section of specification #7
Rewrite Introduction section of specification #7
Conversation
|
||
> **TODO**: Merge this section into the overview/introduction. | ||
While the V2 registry protocol is usable, there are several problems with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused by this:
The specification covers the operation of version 2 of this API
And later:
While the V2 registry protocol is usable, there are several problems with the architecture that have led to this new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you see above from the first line, this was originally labeled "V2.1".
We still need some way of clearing the ambiguity about this not being the same as the "V2" API that was originally defined in docker/docker-registry#612
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence should read "While the V1 registry protocol is usable".
It won't let me comment on the unchanged part, but we should specify that (bolded the addition) "A component of a repository name must be at least two lowercase alphanumeric characters...". Additionally, the regular expression can be changed to |
Signed-off-by: Stephen J Day <stephen.day@docker.com>
@BrianBland I've specified this in prose purposely to avoid the confusion we had about regular expressions before. |
66dc820
to
04552f1
Compare
LGTM |
1 similar comment
LGTM |
Rewrite Introduction section of specification
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
* May 17 live coding Signed-off-by: Josh Dolitsky <josh@dolit.ski> * add vendored Signed-off-by: Josh Dolitsky <josh@dolit.ski> * prototype of new image spec with Reference support * update content-type header Signed-off-by: Akash Singhal <akashsinghal@microsoft.com> Co-authored-by: Josh Dolitsky <josh@dolit.ski>
Signed-off-by: Stephen J Day stephen.day@docker.com