Split PR #12 into separate commits #14
Conversation
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
|
@konstruktoid looks great. Thank you for the PR. |
| @@ -19,6 +19,7 @@ dir_name=`dirname ${this_path}` ## Dir where this file is | |||
| myname=`basename ${this_path}` ## file name of this script. | |||
| logger="${myname}.log" | |||
|
|
|||
| export PATH=/bin:/sbin:/usr/bin | |||
There was a problem hiding this comment.
This line makes this not work on my mac. The reason is that command -v docker now files since my docker binary lives in /usr/local/bin/docker
➜ sh docker-bench-security.sh
docker command not found.Why do we need this change?
There was a problem hiding this comment.
A simple way to reduce risk of the script misbehaving. Some sort of response to Issue #2.
There was a problem hiding this comment.
Well, it removes the ability of running it on my laptop, which is obviously a big no-no ;)
How set are you on this exact directory list? Can we add /usr/local/bin to it?
There was a problem hiding this comment.
You mac users you. ;)
Absolutely, the PATH change is just there to add some sort of basic limitation. As /usr/local/bin is required, it should be added.
There was a problem hiding this comment.
Cool, lets add it and I'll merge it!
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
|
No worries, i'm just glad to help. |
Split PR #12 into separate commits
PR #12 split into seperate commits.
Replacement for earlier requests which was one PR per commit.
Commits individually signed.
@diogomonica, do you want me to clean up this PR mess I've made by closing my previous single-change PRs?
On the millionth PR I might finally figure out this GitHub voodoo...