Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map desc_ to benchmark headings #435

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

konstruktoid
Copy link
Collaborator

Copy benchmark headings and use them as descriptions, including scoring.

Closes #432
Signed-off-by: Thomas Sjögren konstruktoid@users.noreply.github.com

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@konstruktoid konstruktoid merged commit 375d32c into docker:master May 8, 2020
@konstruktoid konstruktoid deleted the scoring branch May 8, 2020 10:42
@ndubbala
Copy link

ndubbala commented May 8, 2020

How did you added all this entries ?manually or any other automated option ?

How this entries helps in counting score and also how to find not scored ?

@ndubbala
Copy link

ndubbala commented May 9, 2020

How do i find which tests are not scored?

if you see below example,total checks are 14 but score is 8.

I want to know where those 6 points of score went

[INFO] 1 - Host Configuration

[INFO] 1.1 - General Configuration
[NOTE] 1.1.1 - Ensure the container host has been Hardened (Not Scored)
[INFO] 1.1.2 - Ensure that the version of Docker is up to date (Not Scored)
[INFO] * Using 19.03.8, verify is it up to date as deemed necessary
[INFO] * Your operating system vendor may provide support and security maintenance for Docker

[INFO] 1.2 - Linux Hosts Specific Configuration
[WARN] 1.2.1 - Ensure a separate partition for containers has been created (Scored)
[INFO] 1.2.2 - Ensure only trusted users are allowed to control Docker daemon (Scored)
[INFO] * docker:x:994:
[PASS] 1.2.3 - Ensure auditing is configured for the Docker daemon (Scored)
[PASS] 1.2.4 - Ensure auditing is configured for Docker files and directories - /var/lib/docker (Scored)
[PASS] 1.2.5 - Ensure auditing is configured for Docker files and directories - /etc/docker (Scored)
[PASS] 1.2.6 - Ensure auditing is configured for Docker files and directories - docker.service (Scored)
[PASS] 1.2.7 - Ensure auditing is configured for Docker files and directories - docker.socket (Scored)
[PASS] 1.2.8 - Ensure auditing is configured for Docker files and directories - /etc/default/docker (Scored)
[INFO] 1.2.9 - Ensure auditing is configured for Docker files and directories - /etc/sysconfig/docker (Scored)
[INFO] * File not found
[PASS] 1.2.10 - Ensure auditing is configured for Docker files and directories - /etc/docker/daemon.json (Scored)
[PASS] 1.2.11 - Ensure auditing is configured for Docker files and directories - /usr/bin/containerd (Scored)
[PASS] 1.2.12 - Ensure auditing is configured for Docker files and directories - /usr/sbin/runc (Scored)

[INFO] Checks: 14
[INFO] Score: 8
[root@localhost docker-bench-security-master]#

@konstruktoid
Copy link
Collaborator Author

It was manual work.

And your score based on the log you pasted:

1.1.1: +0
1.1.2: +0
1.2.1: -1
1.2.2: +0
1.2.3: +1
1.2.4: +1
1.2.5: +1
1.2.6: +1
1.2.7: +1
1.2.8: +1
1.2.9: +0
1.2.10: +1
1.2.11: +1
1.2.12: +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How score count is calculated ?
2 participants