[18.09] Remove need for SUFFIX in gen-deb-ver #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should generate correct bits whether or not the suffix is present. Working example: ❯ ./gen-deb-ver . 18.09.0-beta1 18.09.0~1.1.beta1 18.09.0-beta1 ❯ ./gen-deb-ver . 18.09.0-ce-beta1 18.09.0~ce~1.1.beta1 18.09.0-ce-beta1 Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit 9de3f6f) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
|
Will merge on green since this is a backport |
jgitlin-bt
added a commit
to jgitlin-bt/integration
that referenced
this pull request
Nov 12, 2018
…-packaging#206) so we should just check to see if we're on version >2.x.x
jgitlin-bt
added a commit
to jgitlin-bt/integration
that referenced
this pull request
Nov 13, 2018
…-packaging#206) so we should just check to see if we're on version >2.x.x Changelog: Fix docker version detection Signed-off-by: Josh Gitlin <jgitlin@goboomtown.com>
kacf
pushed a commit
to mendersoftware/integration
that referenced
this pull request
Nov 14, 2018
…-packaging#206) so we should just check to see if we're on version >2.x.x Changelog: Fix docker version detection Signed-off-by: Josh Gitlin <jgitlin@goboomtown.com> (cherry picked from commit a24f3a2)
kacf
pushed a commit
to mendersoftware/integration
that referenced
this pull request
Nov 14, 2018
…-packaging#206) so we should just check to see if we're on version >2.x.x Changelog: Fix docker version detection Signed-off-by: Josh Gitlin <jgitlin@goboomtown.com> (cherry picked from commit a24f3a2)
kacf
pushed a commit
to mendersoftware/integration
that referenced
this pull request
Nov 14, 2018
…-packaging#206) so we should just check to see if we're on version >2.x.x Changelog: Fix docker version detection Signed-off-by: Josh Gitlin <jgitlin@goboomtown.com> (cherry picked from commit a24f3a2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #200
Should generate correct bits whether or not the suffix is present.
Working example:
❯ ./gen-deb-ver . 18.09.0-beta1
18.09.0~1.1.beta1 18.09.0-beta1
❯ ./gen-deb-ver . 18.09.0-ce-beta1
18.09.0
ce1.1.beta1 18.09.0-ce-beta1Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit 9de3f6f)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com