[DO NOT MERGE] WIP Test to build artefacts in the Dockerfile #405
+134
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Oct 28, 2019
|
|
||
| FROM build-base AS deb |
There was a problem hiding this comment.
Haven't tried this stage; the idea will be to;
- build artefacts
- copy them to this stage
- run deb (/rpm) specific steps to package the artefacts as a
.debor.rpm
thaJeztah
force-pushed
the
build_in_dockerfile
branch
from
838d8ff
to
1b19cc6
Compare
Try building as an image ------------------------------- ```bash make \ UBUNTU_VERSIONS=ubuntu-bionic \ DEBIAN_VERSIONS="" \ deb ``` Note that we didn't build containerd or runc, so we can't run the daemon. We can try the cli against a daemon on the host though; ```bash docker run -it --rm -v /var/run/docker.sock:/var/run/docker.sock debbuild-ubuntu-bionic/x86_64 ``` Try building, and put binaries in deb/build -------------------------------------------- ```bash make \ UBUNTU_VERSIONS=ubuntu-bionic \ DEBIAN_VERSIONS="" \ binaries ``` Artefacts will be stored in deb/build ```bash ls -la deb/build total 0 drwx------ 6 sebastiaan staff 192 Oct 28 16:17 . drwxr-xr-x 19 sebastiaan staff 608 Oct 28 16:17 .. drwxr-xr-x 7 sebastiaan staff 224 Oct 28 16:17 bin drwxr-xr-x 4 sebastiaan staff 128 Oct 28 16:17 cli-plugins drwxr-xr-x 6 sebastiaan staff 192 Oct 28 16:17 completion drwxr-xr-x 3 sebastiaan staff 96 Oct 28 16:17 man ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
build_in_dockerfile
branch
from
1b19cc6
to
93352cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some dirty hacking to see what would be needed to build the binaries as part of
docker build, instead of in the deb/rpm specific tools. Still lots of work to be done to make this a usable approach, but doesn't hurt to give it a quick try.Try building as an image
make \ UBUNTU_VERSIONS=ubuntu-bionic \ DEBIAN_VERSIONS="" \ debNote that we didn't build containerd or runc, so
we can't run the daemon. We can try the cli against a
daemon on the host though;
Try building, and put binaries in deb/build
make \ UBUNTU_VERSIONS=ubuntu-bionic \ DEBIAN_VERSIONS="" \ binariesArtefacts will be stored in deb/build
ls -la deb/build total 0 drwx------ 6 sebastiaan staff 192 Oct 28 16:17 . drwxr-xr-x 19 sebastiaan staff 608 Oct 28 16:17 .. drwxr-xr-x 7 sebastiaan staff 224 Oct 28 16:17 bin drwxr-xr-x 4 sebastiaan staff 128 Oct 28 16:17 cli-plugins drwxr-xr-x 6 sebastiaan staff 192 Oct 28 16:17 completion drwxr-xr-x 3 sebastiaan staff 96 Oct 28 16:17 man