[20.10] fix systemd startup order #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the same fix as was added in moby/moby@fe68df3. The systemd unit only contained a `Requires=` for the `docker.socket`, but failed to add it to `After=`. The `Requires=` option only defines that a dependency must be present, but does not influence startup order. From the systemd docs: https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Wants= > Wants= > > (..) > Note that requirement dependencies do not influence the order in which services > are started or stopped. This has to be configured independently with the `After=` > or `Before=` options. (...) As a result, the `docker` service could start before the socket was created, and would fail to start. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
3 tasks
|
@thaJeztah, any news on this being merged? |
|
oh! I forgot this one was still pending. This will have to be reviewed by others. We're looking at doing an extra release of docker engine to include an updated version of @fredericdalleau @tianon ptal |
|
Thanks for review! let's merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same fix as was added in moby/moby@fe68df3, to address docker/for-linux#989 (comment)
The systemd unit only contained a
Requires=for thedocker.socket, but failedto add it to
After=. TheRequires=option only defines that a dependencymust be present, but does not influence startup order. From the systemd docs:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Wants=
As a result, the
dockerservice could start before the socket was created, andwould fail to start.