New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass VERSION to engine static builds #70

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@seemethere
Contributor

seemethere commented Dec 12, 2017

VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

Pass VERSION to engine static builds
VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>

@seemethere seemethere requested a review from docker/tools-and-release-engineering Dec 12, 2017

@seemethere

This comment has been minimized.

Show comment
Hide comment
@seemethere

seemethere Dec 12, 2017

Contributor

Can confirm this works:

root@d5693c93984c:/v/static/build/linux/docker# ./dockerd --version
Docker version 17.12.0-ce-rc2, build 5d7e8f3
Contributor

seemethere commented Dec 12, 2017

Can confirm this works:

root@d5693c93984c:/v/static/build/linux/docker# ./dockerd --version
Docker version 17.12.0-ce-rc2, build 5d7e8f3
@andrewhsu

LGTM

@andrewhsu andrewhsu merged commit 453d9a2 into docker:master Dec 12, 2017

1 check was pending

continuous-integration/jenkins/pr-head This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment