New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.06] Fix error handling with not-exist errors on remove #142

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
4 participants
@cpuguy83
Contributor

cpuguy83 commented Jul 26, 2017

Backport moby/moby#33960 Fix error handling with not-exist errors on remove

Cherry-pick commit moby/moby@d42dbdd

$ git cherry-pick -s -x -Xsubtree=components/engine d42dbdd

@cpuguy83 cpuguy83 changed the title from Fix error handling with not-exist errors on remove to [17.06] Fix error handling with not-exist errors on remove Jul 26, 2017

@andrewhsu andrewhsu added this to the 17.06.1 milestone Jul 26, 2017

Fix error handling with not-exist errors on remove
Specifically, none of the graphdrivers are supposed to return a
not-exist type of error on remove (or at least that's how they are
currently handled).

Found that AUFS still had one case where a not-exist error could escape,
when checking if the directory is mounted we call a `Statfs` on the
path.

This fixes AUFS to not return an error in this case, but also
double-checks at the daemon level on layer remove that the error is not
a `not-exist` type of error.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit d42dbdd)
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jul 26, 2017

Contributor

LGTM

Contributor

vieux commented Jul 26, 2017

LGTM

@vieux vieux merged commit 903138e into docker:17.06 Jul 26, 2017

3 checks passed

ce-tests Jenkins build docker-ce-pr 46 has succeeded
Details
ce-tests-WoW-RS1 Jenkins build docker-ce-pr-WoW-RS1 243 has succeeded
Details
dco-signed All commits are signed

@cpuguy83 cpuguy83 deleted the cpuguy83:cherry-pick-33960 branch Jul 26, 2017

@vieux vieux referenced this pull request Jul 26, 2017

Merged

[17.06] Changelog #129

docker-jenkins pushed a commit that referenced this pull request Aug 17, 2018

Merge pull request #142 from seemethere/remove_rpm_arch
Remove arch specific dockerfiles for RPM building
Upstream-commit: 0d23632daafbdbf93bba0005bc8b595582e88f00
Component: packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment