This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[17.09] back port Automatically set may_detach_mounts=1 on startup
#247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is kernel config available in RHEL7.4 based kernels that enables mountpoint removal where the mountpoint exists in other namespaces. In particular this is important for making this pattern work: ``` umount -l /some/path rm -r /some/path ``` Where `/some/path` exists in another mount namespace. Setting this value will prevent `device or resource busy` errors when attempting to the removal of `/some/path` in the example. This setting is the default, and non-configurable, on upstream kernels since 3.15. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 83c2152) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @cpuguy83 |
|
LGTM |
tonistiigi
pushed a commit
to tonistiigi/docker-ce
that referenced
this pull request
Sep 21, 2017
Add bash completion for `service create|update --entrypoint` Upstream-commit: 1c4d070cf5562525184ac3010ffd1f80e1bb5cc5 Component: cli
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 2, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: 4756a2fba881a2240298b682703203c3768a76dc Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Jun 4, 2019
[19.03 backport] backport layer store optimizations Upstream-commit: 36f0fe6524389e9283e2d57a5ad4992a5ce72bae Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
[17.09] back port Automatically set `may_detach_mounts=1` on startup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back port of moby/moby#34863
This is kernel config available in RHEL7.4 based kernels that enables
mountpoint removal where the mountpoint exists in other namespaces.
In particular this is important for making this pattern work:
Where
/some/pathexists in another mount namespace.Setting this value will prevent
device or resource busyerrors whenattempting to the removal of
/some/pathin the example.This setting is the default, and non-configurable, on upstream kernels
since 3.15.
Signed-off-by: Brian Goff cpuguy83@gmail.com
(cherry picked from commit 83c2152)
Signed-off-by: Sebastiaan van Stijn github@gone.nl