-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline
CHANGELOG
Outdated
### Builder | ||
|
||
* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513) | ||
- Fix build with `ADD` urls without any sub path [moby/moby#34217](https://github.com/moby/moby/pull/34217) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can change this to Add support for ..
, as it wasn't really a bug (imo), more an enhancement
CHANGELOG
Outdated
|
||
* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513) | ||
- Fix build with `ADD` urls without any sub path [moby/moby#34217](https://github.com/moby/moby/pull/34217) | ||
- Fix loader error with different build syntax [docker/cli#544](https://github.com/docker/cli/pull/544) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a fix for docker stack deploy
with a compose file that had a build-section, may have to be moved to a different section
/cc @vdemeester
CHANGELOG
Outdated
### Client | ||
|
||
* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491) | ||
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in a Deprecations
section?
CHANGELOG
Outdated
|
||
* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491) | ||
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821) | ||
* Use nature sort secrets and configs in cli [docker/cli#307](https://github.com/docker/cli/pull/307) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw this in the PR, but s/nature/natural/
is probably better;
* Use natural sort for secrets and configs [docker/cli#307](https://github.com/docker/cli/pull/307)
CHANGELOG
Outdated
* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491) | ||
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821) | ||
* Use nature sort secrets and configs in cli [docker/cli#307](https://github.com/docker/cli/pull/307) | ||
* Use non-detached mode as default for `docker service` commands [docker/cli#525](https://github.com/docker/cli/pull/525) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should put a note/warning/message at the top of the changelog for this to emphasise this change?
CHANGELOG
Outdated
* LCOW: Prepare work for bind mounts [moby/moby#34258](https://github.com/moby/moby/pull/34258) | ||
* LCOW: Support for docker cp, ADD/COPY on build [moby/moby#34252](https://github.com/moby/moby/pull/34252) | ||
* LCOW: VHDX boot to readonly. [moby/moby#34754](https://github.com/moby/moby/pull/34754) | ||
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was cherry-picked into 17.09 7034626#diff-65244c7ec61daa507c915173882e5de3R215 (only in components/cli, but it looks like a client fix)
/cc @dnephin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree this fix is already in 17.09.
CHANGELOG
Outdated
* LCOW: VHDX boot to readonly. [moby/moby#34754](https://github.com/moby/moby/pull/34754) | ||
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770) | ||
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826) | ||
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention SELinux
here?
CHANGELOG
Outdated
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770) | ||
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826) | ||
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792) | ||
* Set selinux label on local volumes from mounts API [moby/moby#34684](https://github.com/moby/moby/pull/34684) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was back ported to 17.09 through #241, so not new
CHANGELOG
Outdated
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826) | ||
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792) | ||
* Set selinux label on local volumes from mounts API [moby/moby#34684](https://github.com/moby/moby/pull/34684) | ||
* Close pipe in overlay2 graphdriver [moby/moby#34863](https://github.com/moby/moby/pull/34863) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was back ported to 17.09 through #245, so not new
CHANGELOG
Outdated
|
||
### Swarm Mode | ||
|
||
* Use limit with `docker swarm init --force-new-cluster` [moby/moby#34881](https://github.com/moby/moby/pull/34881) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps
* Produce an error if `docker swarm init --force-new-cluster` is executed on worker nodes [moby/moby#34881](https://github.com/moby/moby/pull/34881)
CHANGELOG
Outdated
|
||
### Builder | ||
|
||
* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset uid/gid to 0 in uploaded build context to share build cache with other clients
docker/cli#565 was just merged, and needs an entry if we didn't cut off the 17.10 branch yet; * Change the default output format for `docker container stats` to show `CONTAINER ID` and `NAME` [docker/cli#565](https://github.com/docker/cli/pull/565)
+ Add `--no-trunc` flag to `docker container stats` [docker/cli#565](https://github.com/docker/cli/pull/565) |
|
Ah, yes, that should definitely be added, thanks! |
@thaJeztah I addressed most of your comments, feel free to edit the rest directly if you want, I wasn't sure what to do, otherwise, I think it's good for RC1 |
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
LGTM |
1 similar comment
LGTM |
cc @JimGalasyn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andrewhsu FYI CE stuff is me and @gbarr01 :) |
Merged with https://github.com/seemethere/unir Upstream-commit: 8233fbfa68896527ffaef157eb0728c71712d27e Component: packaging
…it_grpc [19.03 backport] Increase max recv gRPC message size for nodes and secrets Upstream-commit: 746dce1994c3062d9c477f29e0578acf4f1da310 Component: engine
No description provided.