Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[17.10] add 17.10 changelog #256

Merged
merged 3 commits into from
Oct 4, 2017
Merged

[17.10] add 17.10 changelog #256

merged 3 commits into from
Oct 4, 2017

Conversation

vieux
Copy link
Contributor

@vieux vieux commented Sep 28, 2017

No description provided.

@vieux
Copy link
Contributor Author

vieux commented Sep 28, 2017

ping @thaJeztah @fcrisciani @tonistiigi

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline

CHANGELOG Outdated
### Builder

* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513)
- Fix build with `ADD` urls without any sub path [moby/moby#34217](https://github.com/moby/moby/pull/34217)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can change this to Add support for .., as it wasn't really a bug (imo), more an enhancement

CHANGELOG Outdated

* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513)
- Fix build with `ADD` urls without any sub path [moby/moby#34217](https://github.com/moby/moby/pull/34217)
- Fix loader error with different build syntax [docker/cli#544](https://github.com/docker/cli/pull/544)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a fix for docker stack deploy with a compose file that had a build-section, may have to be moved to a different section

/cc @vdemeester

CHANGELOG Outdated
### Client

* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491)
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in a Deprecations section?

CHANGELOG Outdated

* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491)
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821)
* Use nature sort secrets and configs in cli [docker/cli#307](https://github.com/docker/cli/pull/307)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this in the PR, but s/nature/natural/ is probably better;

* Use natural sort for secrets and configs [docker/cli#307](https://github.com/docker/cli/pull/307)

CHANGELOG Outdated
* Move output of `docker stack rm` to stdout [docker/cli#491](https://github.com/docker/cli/pull/491)
* Remove deprecated `--enable-api-cors` flag [moby/moby#34821](https://github.com/moby/moby/pull/34821)
* Use nature sort secrets and configs in cli [docker/cli#307](https://github.com/docker/cli/pull/307)
* Use non-detached mode as default for `docker service` commands [docker/cli#525](https://github.com/docker/cli/pull/525)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should put a note/warning/message at the top of the changelog for this to emphasise this change?

CHANGELOG Outdated
* LCOW: Prepare work for bind mounts [moby/moby#34258](https://github.com/moby/moby/pull/34258)
* LCOW: Support for docker cp, ADD/COPY on build [moby/moby#34252](https://github.com/moby/moby/pull/34252)
* LCOW: VHDX boot to readonly. [moby/moby#34754](https://github.com/moby/moby/pull/34754)
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was cherry-picked into 17.09 7034626#diff-65244c7ec61daa507c915173882e5de3R215 (only in components/cli, but it looks like a client fix)

/cc @dnephin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree this fix is already in 17.09.

CHANGELOG Outdated
* LCOW: VHDX boot to readonly. [moby/moby#34754](https://github.com/moby/moby/pull/34754)
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770)
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826)
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention SELinux here?

CHANGELOG Outdated
- Fix volume inspect with empty ID [moby/moby#34770](https://github.com/moby/moby/pull/34770)
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826)
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792)
* Set selinux label on local volumes from mounts API [moby/moby#34684](https://github.com/moby/moby/pull/34684)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was back ported to 17.09 through #241, so not new

CHANGELOG Outdated
- Fix variable shadowing causing LayersSize to be reported as 0 [moby/moby#34826](https://github.com/moby/moby/pull/34826)
* Volume: evaluate symlinks before relabeling mount source [moby/moby#34792](https://github.com/moby/moby/pull/34792)
* Set selinux label on local volumes from mounts API [moby/moby#34684](https://github.com/moby/moby/pull/34684)
* Close pipe in overlay2 graphdriver [moby/moby#34863](https://github.com/moby/moby/pull/34863)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was back ported to 17.09 through #245, so not new

CHANGELOG Outdated

### Swarm Mode

* Use limit with `docker swarm init --force-new-cluster` [moby/moby#34881](https://github.com/moby/moby/pull/34881)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

* Produce an error if `docker swarm init --force-new-cluster` is executed on worker nodes [moby/moby#34881](https://github.com/moby/moby/pull/34881)

CHANGELOG Outdated

### Builder

* Reset uid/gid to 0 in build context to fix cache busting issues on `ADD/COPY` [docker/cli#513](https://github.com/docker/cli/pull/513)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset uid/gid to 0 in uploaded build context to share build cache with other clients

@thaJeztah
Copy link
Member

docker/cli#565 was just merged, and needs an entry if we didn't cut off the 17.10 branch yet;

* Change the default output format for `docker container stats` to show `CONTAINER ID` and `NAME` [docker/cli#565](https://github.com/docker/cli/pull/565)
+ Add `--no-trunc` flag to `docker container stats` [docker/cli#565](https://github.com/docker/cli/pull/565)

@dnephin
Copy link
Contributor

dnephin commented Sep 28, 2017

docker trust is in experimental for 17.10 , right? Should we mention it?

@thaJeztah
Copy link
Member

Ah, yes, that should definitely be added, thanks!

@vieux
Copy link
Contributor Author

vieux commented Sep 29, 2017

@thaJeztah I addressed most of your comments, feel free to edit the rest directly if you want, I wasn't sure what to do, otherwise, I think it's good for RC1

@andrewhsu andrewhsu changed the base branch from master to 17.10 September 29, 2017 22:42
vieux and others added 3 commits September 29, 2017 15:47
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@vieux
Copy link
Contributor Author

vieux commented Sep 29, 2017

LGTM

1 similar comment
@tonistiigi
Copy link
Contributor

LGTM

@andrewhsu andrewhsu added this to the 17.10.0 milestone Sep 29, 2017
@vieux vieux changed the title [WIP] [17.10] add 17.10 changelog [17.10] add 17.10 changelog Sep 30, 2017
@andrewhsu
Copy link
Contributor

cc @JimGalasyn

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 8ab000a into docker-archive:17.10 Oct 4, 2017
@mdlinville
Copy link
Contributor

@andrewhsu FYI CE stuff is me and @gbarr01 :)

@vieux vieux deleted the 17.10-changelog branch October 4, 2017 22:30
docker-jenkins pushed a commit that referenced this pull request Nov 15, 2018
Merged with https://github.com/seemethere/unir
Upstream-commit: 8233fbfa68896527ffaef157eb0728c71712d27e
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Jun 4, 2019
…it_grpc

[19.03 backport] Increase max recv gRPC message size for nodes and secrets
Upstream-commit: 746dce1994c3062d9c477f29e0578acf4f1da310
Component: engine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants