Bump Version to 19.03.6

[arkodg]

This PR attempts to move the docker-ce 19.03.6 package from the test to the stable channel for consumption

[arkodg]

PTAL @AkihiroSuda @cpuguy83 @thaJeztah @tiborvass @tonistiigi
Do we need more additions in the CHANGELOG ?

[cpuguy83]

LGTM

[thaJeztah]

Looks like components/engine is one commit behind tip of 19.03; latest commit there is 6e493ff, which corresponds with https://github.com/moby/moby/compare/5f6d6f3f220355e6db7167ba82bc2def47a013d0 upstream, and is one commit/PR behind:

moby/moby@5f6d6f3...19.03

Not critical, but in case we're tagging the 19.03 branch on the wrong commit

[cpuguy83]

Should be the same commit as rc2?

[arkodg]

@thaJeztah that commit has been merged 76a635b

[silvin-lubecki]

LGTM

[thaJeztah]

@arkodg correct; but the components/engine in this repository does not have it, which means that either;

• we build with what's currently here, and move [19.03 backport] dockerd-rootless.sh: remove confusing code comment moby/moby#40460 to the 19.03.7 milesone
  • make sure that we tag moby/moby@5f6d6f3 as 19.03.6 (and NOT moby/moby@130ae89)
• or, we merge [19.03] components: use moby/moby instead of docker/engine #642, run the "update components" job, and include [19.03 backport] dockerd-rootless.sh: remove confusing code comment moby/moby#40460 in 19.03.6

[tiborvass]

@arkodg

that commit has been merged 76a635b

If "that commit" refers to moby/moby@9338d0a, I would disagree.

Now, I don't think that's a problem, and yes we should only tag the right commit, not the latest in the 19.03 branch.

[thaJeztah]

should only tag the right commit, not the latest in the 19.03 branch.

Yes, that's the issue. Not critical, but I know things have (almost) gone wrong there in the past

[arkodg]

I would prefer to merge #642, run the "update components" job, and include moby/moby#40460 in 19.03.6