rewrite tests to use sub-tests, improve error-handling in tests, and use t.Cleanup() #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 55.55% 55.35% -0.20%
==========================================
Files 9 9
Lines 666 672 +6
==========================================
+ Hits 370 372 +2
- Misses 253 257 +4
Partials 43 43
☔ View full report in Codecov by Sentry. |
thaJeztah
force-pushed
the
subtests
branch
2 times, most recently
from
59cb6ec
to
fae61fc
Compare
Mostly for my own sanity; just about every repository we have started to converge to using "tc" as variable name for this, so updating this repository as well to help reduce cognitive load. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also reformat the test-table to easier see what fields are used for each test in the table. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also moving the comments into the test-tables. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make sure we don't drop errors when cleaning up state before/after tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also moving the comments into the test-tables. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make sure we don't drop errors when cleaning up state before/after tests. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- don't fail tests early if there's more we can test - don't user un-keyed literals in tests Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- use consts for fixed values in tests - don't fail tests early if there's more we can test Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 task
|
This one should be ready for review now as well; @crazy-max PTAL ❤️ |
crazy-max
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details