chore: use go build constraint #289
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 54.68% 52.74% -1.94%
==========================================
Files 9 9
Lines 673 673
==========================================
- Hits 368 355 -13
- Misses 262 271 +9
- Partials 43 47 +4
☔ View full report in Codecov by Sentry. |
|
@thaJeztah I just noticed that this would solve #277 as well |
pass/pass.go
Outdated
| @@ -1,3 +1,6 @@ | |||
| //go:build linux || darwin | |||
There was a problem hiding this comment.
slightly on the fence on this one; I think the code in this repo works fine on any platform (if there's a pass binary to shell out to?)
There was a problem hiding this comment.
agree, switched to unix.
There was a problem hiding this comment.
actually !windows looks better.
There was a problem hiding this comment.
So for the pass helper; I guess the thing I was wondering here was that;
- the code in this repository (the helper itself) is basically platform-agnostic (including Windows)
- the "only" limitation we have for testing is that we don't have a
passbinary on Windows - so, wondering if we should actually exclude it on Windows?
- (but indeed, we can't currently run the tests, as those depend on a
passbinary) - ^^ do we know if there's an implementation of the
passbinary for windows?
There was a problem hiding this comment.
It looks like there's at least one implementation (although last release is really old; https://github.com/mbos/Pass4Win)
There was a problem hiding this comment.
Tried to install Pass4Win in ci but binary is not named pass.exe 😣 https://github.com/docker/docker-credential-helpers/actions/runs/5110526809/jobs/9186513917#step:9:8
So disable tests for windows in the meantime. Let me know if you prefer a specific tag like exclude_pass_tests that would be just set in CI.
crazy-max
force-pushed
the
build-constraint
branch
2 times, most recently
from
8bc3973
to
239923b
Compare
crazy-max
force-pushed
the
build-constraint
branch
3 times, most recently
from
2791d66
to
a031c52
Compare
|
Look like it timed out or so 😔 |
crazy-max
force-pushed
the
build-constraint
branch
2 times, most recently
from
399b954
to
492a7b1
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
build-constraint
branch
from
492a7b1
to
72391b3
Compare
|
@thaJeztah PTAL when you can 🙏, would like to rebase #288 |
fixes #176
Switch to go build constraint. This allows to run tests against the right architecture. Errors in
passtests are now properly handled.