credentials: improve errors and error-handling #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
- Coverage 52.74% 52.51% -0.24%
==========================================
Files 9 9
Lines 673 676 +3
==========================================
Hits 355 355
- Misses 271 274 +3
Partials 47 47
☔ View full report in Codecov by Sentry. |
crazy-max
approved these changes
Jun 15, 2023
|
Doh! my commit description says |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This allows for checking the error-type returned to be matched with the errdefs utilities. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
errors_improvements
branch
from
1e3101c
to
a228f55
Compare
|
Fixed 😅 |
crazy-max
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credentials: use errors.Is() to match error-types
credentials: implement errdefs types for typed errors
This allows for checking the error-type returned to be matched with the errdefs utilities.