Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a better displaylabel for secretservice #324

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on May 13, 2024

  1. Set a better displaylabel for secretservice

    Secretservice entries have a "label". This is intended to be a
    human-readable description. It's actually called "Description" in UIs
    like seahorse, and the listing of existing secrets shows this as a name
    for each one.
    
    The entries stored by the credential helper set this to simply the
    repository URL. This is rather unfriendly, since entries like
    "gitlab.com" and "index.docker.io/v1" show up. Mixed in with
    entries from all other applications, it's hard to figure out what
    application owns each entry.
    
    This commit changes the label used when saving entries to be something
    human-readable (this is the intent of the "label" field, btw). Because
    of the naming scheme, this also results in all entries being shown
    together by default (since UIs tend to sort lexicographically).
    
    New entries will now be stores as:
    
      Docker credentials for $REGISTRY_URL
    
    Note that items stored by the secret service have multiple fields inside
    of them. One of those fields is called "label", and is used by the
    helper to filter items from the secret service. This "label" field is
    entirely unrelated to the items' label. The naming is most unfortunate.
    
    Signed-off-by: Hugo Osvaldo Barrera <hugo@barrera.io>
    Hugo Osvaldo Barrera authored and thaJeztah committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c805249 View commit details
    Browse the repository at this point in the history