Add VERSION pinning to the installation script #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
force-pushed
the
add_version_pinning
branch
2 times, most recently
from
a974a1c
to
f453a99
Compare
VERSION pinning is something that people have been asking for, for a while so this attempts to add that in. Should work in most scenarios aside from incomplete VERSIONS. IE: If you have the `test` channel enabled and try to install `17.12` for example, the script will instead try to install rc2 since that is the latest VERSION in the results. Should also work with nightly builds like pinning to a date, or a specific git SHA Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
seemethere
force-pushed
the
add_version_pinning
branch
from
f453a99
to
efeeb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
VERSION pinning is something that people have been asking for, for a
while so this attempts to add that in.
Should work in most scenarios aside from incomplete VERSIONS.
IE: If you have the
testchannel enabled and try to install17.12for example, the script will instead try to install rc2 since that is
the latest VERSION in the results.
Should also work with nightly builds like pinning to a date, or a
specific git SHA
Relates to #61 as well as docker/machine#4091
Usage
Usage would be similar to
CHANNELpinning:Signed-off-by: Eli Uriegas eli.uriegas@docker.com