-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-py should support same URL schemes as Docker #166
Comments
Already in master: see #140 |
Sorry, I should have been clearer. docker-py supports some of the values of DOCKER_HOST. Here are some things it doesn't support, for example:
It should all work if the logic from Docker's |
I'll hold out on making changes for now because I believe |
Fig received docker/compose#88 because it blindly passes
DOCKER_HOST
to thebase_url
arg toClient
.Maybe
base_url
should support things liketcp://
, as per https://github.com/dotcloud/docker/blob/2723133a69a292abaa021afff98de127bda57b4e/utils/utils.go#L753-L807 . Alternatively, it could be a separate constructor method.The text was updated successfully, but these errors were encountered: