Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-py should support same URL schemes as Docker #166

Closed
bfirsh opened this issue Feb 10, 2014 · 3 comments · Fixed by #259
Closed

docker-py should support same URL schemes as Docker #166

bfirsh opened this issue Feb 10, 2014 · 3 comments · Fixed by #259

Comments

@bfirsh
Copy link
Contributor

bfirsh commented Feb 10, 2014

Fig received docker/compose#88 because it blindly passes DOCKER_HOST to the base_url arg to Client.

Maybe base_url should support things like tcp://, as per https://github.com/dotcloud/docker/blob/2723133a69a292abaa021afff98de127bda57b4e/utils/utils.go#L753-L807 . Alternatively, it could be a separate constructor method.

@shin-
Copy link
Contributor

shin- commented Feb 11, 2014

Already in master: see #140

@shin- shin- closed this as completed Feb 11, 2014
@bfirsh
Copy link
Contributor Author

bfirsh commented Feb 11, 2014

Sorry, I should have been clearer. docker-py supports some of the values of DOCKER_HOST. Here are some things it doesn't support, for example:

  • tcp://
  • :4243
  • localhost
  • localhost:4243

It should all work if the logic from Docker's ParseHost is reproduced.

@shin- shin- reopened this Feb 12, 2014
@shin-
Copy link
Contributor

shin- commented Feb 24, 2014

I'll hold out on making changes for now because I believe ParseHost will undergo some changes very soon in the main project, which could invalidate or change the scope of this request. Leaving it open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants