Support same URL schemes as Docker #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of Client's base_url. Unit tests
|
This is still a breaking change, the original implementation doesn't allow to leave the port unspecified while docker-py currently does. We can either stick with it and release a new major (it's kinda overdue anyway), or allow the port to be unspecified, with the potential security implications that this has. LMK what you think. |
|
LGTM |
|
/cc @aanand |
|
LGTM too. If the Docker CLI doesn't allow an unspecified port, I don't think docker-py should either - and if it's a breaking change, so be it! |
|
Thanks for the review guys :) merging! |
shin-
added a commit
that referenced
this pull request
Jul 9, 2014
Support same URL schemes as Docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
@bfirsh @mpetazzoni I think I'm accounting for all the current and future use cases with this, but please review and let me know if I missed something.