Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build images with tag with https prefix never ends #3153

Closed
axel7083 opened this issue Jul 4, 2023 · 1 comment · Fixed by #3191
Closed

build images with tag with https prefix never ends #3153

axel7083 opened this issue Jul 4, 2023 · 1 comment · Fixed by #3191

Comments

@axel7083
Copy link

axel7083 commented Jul 4, 2023

Reproduces

docker_client = docker.from_env()
docker_client .images.build(path="{my-path}", tag="https://dummy:latest", dockerfile="{dockerfile-path})

Using the debugger, we can see it loop on the _post request here:

response = self._post(
u,
data=context,
params=params,
headers=headers,
stream=True,
timeout=timeout,
)

@naufalafif
Copy link

https://dummy:latest is not a valid image tag

Docker image tags can only contain lowercase and uppercase letters, digits, underscores, periods, and dashes. https://docs.docker.com/engine/reference/commandline/tag/

if you are trying to use custom registry, there's no need to add https prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants