Move cpu_shares and cpuset_cpu to HostConfig when API >= 1.18 #1160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
cpu_share
andcpuset_cpus
options toHostConfig
, per the Docker remote API >= 1.18.Previously
cpu_share
andcpuset
arguments were passed intocreate_container
as kwargs. I've added an InvalidVersion exception there, when the API version is < 1.18 and these arguments are passed. I can't seem to find documentation for < 1.18 to know if this should be a warning instead?I should also note I've renamed
cpuset
tocpuset_cpus
to match the existingcontainer_update
functionality, which is already expecting these being inHostConfig
.Related issues: #1030, docker/compose#3284, docker-archive/classicswarm#1983