Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of DOCKER_API_VERSION env variable #2139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Matzz
Copy link

@Matzz Matzz commented Sep 21, 2018

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "master" git@github.com:Matzz/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Mateusz Zakarczemny <m.zakarczemny+githyb@gmail.com>
@little-dude
Copy link
Contributor

I'd like to have that. Are you planning to finish this up @Matzz / @onzo-mateuszzakarczemny ? Otherwise can I pick it up?

@@ -60,6 +60,11 @@ def from_env(cls, **kwargs):
A path to a directory containing TLS certificates to use when
connecting to the Docker host.

.. envvar:: DOCKER_API_VERSION

A path to a directory containing TLS certificates to use when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description doesn't seem right

@onzo-mateuszzakarczemny

I'd like to have that. Are you planning to finish this up @Matzz / @onzo-mateuszzakarczemny ? Otherwise can I pick it up?

Hi. Sorry I forgot about this PR. I had some issues with make it working and did some workaround instead of finishing that.
Feel free to pick it if you want.

@ulyssessouza
Copy link
Collaborator

@little-dude Are you interested in fixing this? (Or anyone else)
For that you just need to rebase with master to make it pass the CI and fix the comment as suggested by @TomasTomecek in Please rebase the PR with master to make it pass the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants