Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing the revert suggested by @shin- ages ago #2300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abrugh
Copy link

@abrugh abrugh commented Mar 29, 2019

Fixes the issue described, tested and reproduced in docker/compose#6018

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "6018" git@github.com:abrugh/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ulyssessouza
Copy link
Collaborator

This PR is not passing due to an already solved problem.
Please rebase your PR with master

Signed-off-by: Alexander Brugh <alex@brugh.net>
@abrugh
Copy link
Author

abrugh commented Apr 4, 2019

Rebased, still failing AttachContainerTest::test_attach_stream_and_cancel but only 2 out of 4 times....

@shin-
Copy link
Contributor

shin- commented Apr 4, 2019

Looks like it's failing pretty consistently on Python 2.7 (if you look at the test matrix here). To me that suggests that that condition does something helpful, and the fix is less trivial than it appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants