Fix reading from socket extracted from HTTPResponse #2467
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPResponse access the underlying socket via an io.BufferedReader object, that may still have "unread" bytes in its internal buffer when the socket is extracted from HTTPResponse. Preserve those bytes in an attribute of the socket object at the time of the extraction so that they are not lost. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPResponse access the underlying socket via an io.BufferedReader
object, that may still have "unread" bytes in its internal buffer when
the socket is extracted from HTTPResponse.
Preserve those bytes in an attribute of the socket object at the time
of the extraction so that they are not lost.
Signed-off-by: Sergei Trofimov sergei.trofimov@arm.com