Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit parameter to image search endpoint #2476

Merged
merged 1 commit into from Apr 6, 2021

Conversation

feliperuhland
Copy link
Contributor

  • Add limit parameter to image search endpoint - 901f857

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "add-search-images-limit" git@github.com:feliperuhland/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@feliperuhland
Copy link
Contributor Author

Hi @ulyssessouza @chris-crone @shin-

Could you please take a look?

Thanks!

Signed-off-by: Felipe Ruhland <felipe.ruhland@gmail.com>
@feliperuhland
Copy link
Contributor Author

Hi @ulyssessouza @shin-
Could you please take a look?

Thanks!

@feliperuhland
Copy link
Contributor Author

Hi @ulyssessouza @shin- @aiordache
Could you please take a look?

Thanks!

Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@aiordache aiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@aiordache aiordache added this to the 4.5.0 milestone Apr 6, 2021
@aiordache aiordache merged commit 18fdc23 into docker:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants