Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of credentials not found for docker-credential-desktop #2499

Closed
wants to merge 1 commit into from

Conversation

fopina
Copy link

@fopina fopina commented Jan 30, 2020

Can't pull any public image as this store returns a slightly different message than the one hardcoded, raising the wrong exception (StoreError instead of CredentialsNotFound)

echo 'https://index.docker.io/v1/' | docker-credential-desktop get
No stored credential for https://index.docker.io/v1/

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:fopina/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Pina <fopina@gmail.com>
@fopina
Copy link
Author

fopina commented Jan 30, 2020

appveyor tests failing seem to be related to their default setup having changed..

@fopina
Copy link
Author

fopina commented Nov 14, 2020

Should I close this?

@fopina fopina closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants