Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkinsfile: remove obsolete engine versions #2514

Merged
merged 2 commits into from Feb 21, 2020
Merged

Jenkinsfile: remove obsolete engine versions #2514

merged 2 commits into from Feb 21, 2020

Conversation

thaJeztah
Copy link
Member

No description provided.

@thaJeztah
Copy link
Member Author

ping @ndeloof @ulyssessouza PTAL

@thaJeztah
Copy link
Member Author

Hmm.. is this depending on legacy swarm images, or are these different images?


+ docker run -d --name dpy-dind-2-0-py3.7-19.03 -v /tmp --privileged --network dpy-testnet-2-0-py3.7-19.03 dockerswarm/dind:19.03 dockerd -H tcp://0.0.0.0:2375
Unable to find image 'dockerswarm/dind:19.03' locally
docker: Error response from daemon: manifest for dockerswarm/dind:19.03 not found: manifest unknown: manifest unknown.
See 'docker run --help'.
script returned exit code 1

@thaJeztah
Jenkinsfile: remove obsolete engine versions
789b671 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Update test engine version to 19.03.5
7bef5e8 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ulyssessouza
ulyssessouza approved these changes Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit 030af62 into docker:master Feb 21, 2020
@thaJeztah thaJeztah deleted the remove_obsolete_versions branch February 21, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulyssessouza ulyssessouza ulyssessouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaJeztah @ulyssessouza