Disable compression by default when using container:get_archive method #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:Nicceboy/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Niklas Saari <niklas.saari@tutanota.com>
|
Thanks! @ulyssessouza @shin- @ndeloof PTAL |
|
Any updates about this? |
|
ping @ulyssessouza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pre-discussion can be found from here: moby/moby#40577
This PR attempts to disable compression by default and parametrize the encoding of data stream, when using container's get_archive method. This should bring similar performance than command
docker cphas when copying files from container as tar file into host system.Current implementation is not giving any headers for this GET request, and this causes the use of default headers of
requestslibrary:Accept-Encoding: gzip, deflate.This makes Docker engine to encode response stream as gzip-compressed format, and this slows download speed a lot.
I'm not sure if giving possibility for parameter is that useful, but maybe there are some use cases where network bandwidth is bottleneck, and compression could be helpful.