New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests to support both log plugin feedbacks #2549
Conversation
51be7a4
to
daa9e2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a python code, but this seems sane to me, thanks!
LGTM
Looks like tests are failing on something else (unrelated); @ulyssessouza could you have a look? |
Looks like it was just a flaky test... The only thing missing is to have the |
91c93c0
to
390aca3
Compare
Signed-off-by: Wilson Júnior <wilsonpjunior@gmail.com> Docker-DCO-1.1-Signed-off-by: Wilson Júnior <wilsonpjunior@gmail.com> (github: wpjunior)
390aca3
to
7d92fbd
Compare
Hi @ulyssessouza how can I complete dco-signed check ?, I signed my commits with related signature and it is not work. |
I think only the first one is supported (the Can you remove the last ( |
Oh! Besides that, @ulyssessouza I see you enabled the If you disable the "required" check, things should pass |
Unfortunately, I don't have write/admin access on this repository otherwise I'd have updated that setting, but @wpjunior if you can update the commit message, then things should be OK from your side 🤗 |
Got it merged! @wpjunior Obrigado pela PR! |
I am improving the feedback when docker uses a log driver, could you see the change at: moby/moby#40807.
After above change I broke one test that is inside this project, then, I am sending the fix.
Thanks.