Add device requests #2581
Closed
Add device requests #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erwan Rouchet <rouchet@teklia.com>
Signed-off-by: Erwan Rouchet <rouchet@teklia.com>
Signed-off-by: Erwan Rouchet <rouchet@teklia.com>
Signed-off-by: Erwan Rouchet <rouchet@teklia.com>
Signed-off-by: Erwan Rouchet <rouchet@teklia.com>
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
Merged
|
Anything blocking this PR? |
ghost
mentioned this pull request
|
Waiting on review |
|
Thanks for your work ! I'm waiting for the build to finish on #2471, then i'll add a comment there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made before teklia#1 was merged, and is now a duplicate of #2471. This introduced a fix for the failing test by creating a 1.40 client specific for that test.
Unfortunately, looks like User-Agent needs to be allowed in the request headers. Not sure why, possibly a requirement of the v1.40 API, but it could be that I'm not setting up the environment correctly.