Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test engine version to 19.03.12 #2584

Merged
merged 1 commit into from Aug 7, 2020
Merged

Update test engine version to 19.03.12 #2584

merged 1 commit into from Aug 7, 2020

Conversation

thaJeztah
Copy link
Member

No description provided.

thaJeztah
thaJeztah commented Jun 3, 2020
View reviewed changes
Jenkinsfile Outdated
@@ -66,7 +66,7 @@ def runTests = { Map settings ->
throw new Exception("Need test image object, e.g.: `runTests(testImage: img)`")
}
if (!dockerVersion) {
throw new Exception("Need Docker version to test, e.g.: `runTests(dockerVersion: '1.12.3')`")
throw new Exception("Need Docker version to test, e.g.: `runTests(dockerVersion: '19.03.11')`")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really important, but thought it would be clearer to use a more realistic example in the error

@thaJeztah
Copy link
Member Author

Interesting; build failing on Jenkins;

https://ci-next.docker.com/public/blue/organizations/jenkins/docker-py/detail/PR-2584/1/pipeline

 docker build -t dockerbuildbot/docker-py:py2-5dea12f791bb8771553d21478015548bd7bb877f -f tests/Dockerfile --build-arg PYTHON_VERSION=2.7 .
...
Digest: sha256:cfa62318c459b1fde9e0841c619906d15ada5910d625176e24bf692cf8a2601d
Status: Downloaded newer image for python:2.7
 ---> 68e7be49c28c
Step 3/19 : ARG APT_MIRROR
 ---> Running in 686edd7e1190
Removing intermediate container 686edd7e1190
 ---> 733dc05c5fd9
Step 4/19 : RUN sed -ri "s/(httpredir|deb).debian.org/${APT_MIRROR:-deb.debian.org}/g" /etc/apt/sources.list  && sed -ri "s/(security).debian.org/${APT_MIRROR:-security.debian.org}/g" /etc/apt/sources.list
 ---> Running in 1969c958d278
cgroups: cgroup mountpoint does not exist: unknown
script returned exit code 1

This is on an Ubuntu 19.10 machine;

Running on EC2 (managed-agents) - ubuntu-1910-overlay2 (i-01a0f5382e883adc8) in /home/ubuntu/workspace/docker-py_PR-2584

@thaJeztah
Copy link
Member Author

Oh! I think these are the nodes that were setup for testing cgroups v2 @StefanScherer ?

StefanScherer
StefanScherer reviewed Jun 3, 2020
View reviewed changes
Jenkinsfile Outdated
@@ -31,7 +31,7 @@ def buildImages = { ->
}

def getDockerVersions = { ->
def dockerVersions = ["19.03.5"]
def dockerVersions = ["19.03.11"]
wrappedNode(label: "ubuntu && !zfs && amd64") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It picked Ubuntu 19.10 randomly.
Should we pin it better by using a label ubuntu-1804?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we remove the ubuntu-1910 machine again? Maybe better and add ubuntu-2004 LTS machines instead. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably, or do you have ideas for a labelling scheme where those nodes are not selected in the "regular" pools?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, our comments crossed LOL

I just opened #2585

@thaJeztah thaJeztah mentioned this pull request Jun 3, 2020
Merged
@thaJeztah
Copy link
Member Author

rebased, as #2585 was merged

@StefanScherer @ulyssessouza PTAL

StefanScherer
StefanScherer approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Update test engine version to 19.03.12
2c68b38 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah changed the title Update test engine version to 19.03.11 Update test engine version to 19.03.12 Jun 30, 2020
@thaJeztah
Copy link
Member Author

Updated to 19.03.12

chris-crone
chris-crone approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiordache aiordache merged commit 62afadc into docker:master Aug 7, 2020
@thaJeztah thaJeztah deleted the bump_engine branch August 7, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanScherer StefanScherer StefanScherer approved these changes

@chris-crone chris-crone chris-crone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thaJeztah @StefanScherer @chris-crone @aiordache