Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file environment variable to integration-dind #2641

Merged

Conversation

YuviGold
Copy link
Contributor

@YuviGold YuviGold commented Aug 16, 2020

Support running specific test files inside integration-dind Makefile targets
This environment variable already exist in the integration tests.

@ulyssessouza @thaJeztah

Signed-off-by: Yuval Goldberg <yuvigoldi@hotmail.com>
@YuviGold YuviGold force-pushed the feature/extend-file-variable-usage branch from 2e09920 to 5d1f55d Compare August 16, 2020 15:58
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

looks the same approach as the existing targets

Copy link
Collaborator

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit 0dfae33 into docker:master Aug 18, 2020
@YuviGold YuviGold deleted the feature/extend-file-variable-usage branch August 19, 2020 06:10
@aiordache aiordache added this to the 4.3.1 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants