auth_config build function support #2647
Open
+78
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a side note, I ran autopep8 to deal with all the blank spaces but I wonder if this could be done automatically by the automation, it may help get PRs green faster. Attached the command: |
Signed-off-by: Yuval Goldberg <yuvigoldi@hotmail.com> Signed-off-by: jcardenes <jcardenes@viascience.com>
This is needed as otherwise any image relying on a private registry as in FROM private_image currently fails authentication Signed-off-by: jcardenes <jcardenes@viascience.com>
With this update build() should be able to also build images relying on private registries as in: FROM private_image Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Depending of feedback, I will refactor this unittest Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
Signed-off-by: jcardenes <jcardenes@viascience.com>
|
On my comment on automated styling there are some Github tools that may help |
| # client = make_fake_client() | ||
| # image = client.images.build(auth_config={"auth":1}) | ||
| # client.api.build.assert_called_with() | ||
| # client.api.inspect_image.assert_called_with( |
There was a problem hiding this comment.
Not sure why the call to inspect_image here.
| @utils.check_resource('image') | ||
| def inspect_image(self, image): | ||
| def inspect_image(self, image, auth_config=None): |
There was a problem hiding this comment.
Instead of passing auth_config on all the client methods, you could just create a setter for it in the client.
That would also help you with the commented unit test when checking the inspect.
Good point! Co-authored-by: Ulysses Souza <ulysses.souza@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow the build function to support images relying on private registries as their base docker image layers, as in:
FROM private_image