Fix plugin model upgrade #2687
Merged
Fix plugin model upgrade #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When upgrading a plugin via the model interface, it would yield the
following error:
AttributeError: 'Plugin' object has no attribute '_reload'
It appears that the proper method is `self.reload()`. This is what is
used by all other methods in the class and base. I'm not finding any
references to `_reload` apart from this instance in the project either.
I've verified that this patch fixes the issue on my machine and all
tests pass.
Signed-off-by: Ian Fijolek <ian@iamthefij.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a plugin via the model interface, it would yield the
following error:
It appears that the proper method is
self.reload(). This is what isused by all other methods in the class and base. I'm not finding any
references to
_reloadapart from this instance in the project either.I've verified that this patch fixes the issue on my machine and all
tests pass.
Signed-off-by: Ian Fijolek ian@iamthefij.com
Fixes #2685