Add max_pool_size parameter #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
|
I've closed my old PR, hoping that this time it is ok! |
Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
chris-crone
reviewed
Nov 16, 2020
docker/api/client.py
Outdated
Comment on lines
106
to
107
| max_pool_size=DEFAULT_MAX_POOL_SIZE, credstore_env=None, | ||
| use_ssh_client=False): |
There was a problem hiding this comment.
I would move the newest parameter to the end of the list so that if users are using this constructer with positional parameters, it will continue to work as expected.
Suggested change
| max_pool_size=DEFAULT_MAX_POOL_SIZE, credstore_env=None, | |
| use_ssh_client=False): | |
| credstore_env=None, use_ssh_client=False, | |
| max_pool_size=DEFAULT_MAX_POOL_SIZE): |
There was a problem hiding this comment.
@chris-crone, I did it. Thanks for the suggestion! 😄
Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
aiordache
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Add max_pool_size parameter Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com> * Add client version to tests Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com> * Fix parameter position Signed-off-by: Mariano Scazzariello <marianoscazzariello@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the connection pools (UNIX socket/NPipe and SSH) are limited to a pool of 10 threads. This value is hardcoded in the Python code, so it can't be changed.
This pull request adds a
max_pool_sizeparameter in the Client that makes able to tweak the number of thread for each connection pool used by the library. Of couse, by default this value is set to 10.This feature was requested in #2477. We already opened a PR 1 year ago but we had some problems with the commits signatures.