Update Jenkinsfile with docker registry credentials #2705
Conversation
Signed-off-by: aiordache <anca.iordache@docker.com>
| buildImage(imageDindSSH, "-f tests/Dockerfile-ssh-dind .", "") | ||
| buildImage(imageNamePy2, "-f tests/Dockerfile --build-arg PYTHON_VERSION=2.7 .", "py2.7") | ||
| buildImage(imageNamePy3, "-f tests/Dockerfile --build-arg PYTHON_VERSION=3.7 .", "py3.7") | ||
| withDockerRegistry(credentialsId:'dockerbuildbot-index.docker.io') { |
There was a problem hiding this comment.
can we use an unprivileged account, and no access to any private images in the docker namespaces? ideally a PAT
There was a problem hiding this comment.
We just compared it to the docker/compose repo and used the same here. 😅
And this pipeline also pushes the images. 🤔
There was a problem hiding this comment.
Do we have a better hub account that we could use?
There was a problem hiding this comment.
if needed, we could create one perhaps
There was a problem hiding this comment.
If it's currently pushing; what credentials does it use for that?
(sorry for brevity; on my phone 😂)
There was a problem hiding this comment.
I've updated the Jenkins secret to use a PAT instead of the real password.
|
According to https://ci-next.docker.com/public/blue/rest/organizations/jenkins/pipelines/docker-py/branches/master/runs/48/nodes/81/steps/135/log/?start=0 we probably have to change the tests and not the Jenkinsfile to fix the rate limiting. |
Signed-off-by: aiordache <anca.iordache@docker.com>
| -e 'DOCKER_TEST_API_VERSION=${apiVersion}' \\ | ||
| --network ${testNetwork} \\ | ||
| --volumes-from ${dindContainerName} \\ | ||
| -v ~/.docker/config.json:/root/.docker/config.json \\ |
There was a problem hiding this comment.
Better watched in diff mode without white space changes.
This does the trick for the DIND environment to login.
There was a problem hiding this comment.
LGTM
we could change the Docker Hub account in another PR, this PR helps @aiordache to get a release out.
Add registry credentials to avoid being rate limited.