fix(dockerignore): trim trailing whitespace #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalioz
force-pushed
the
fix-dockerignore-trailing-whitespace
branch
from
1b98235
to
6d38ea4
Compare
Signed-off-by: Clément Loiselet <clement.loiselet@capgemini.com>
kalioz
force-pushed
the
fix-dockerignore-trailing-whitespace
branch
from
6d38ea4
to
ab22f08
Compare
|
Jenkins builds crash because of reasons outside of this PR 😥 I'll try to re-trigger it tomorrow, unless a kind soul can trigger it directly on jenkins without pushing to git :) |
milas
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Thanks for your PR! And you're absolutely correct, our docs do say:
A preprocessing step removes leading and trailing whitespace and eliminates . and .. elements using Go’s filepath.Clean. Lines that are blank after preprocessing are ignored.
(emphasis mine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the trailing whitespaces in dockerignore files, allowing the following structure to be conform to the official
dockerbuild.fixes #2732