New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host trimming and remove quiet flag for the ssh connection #2755

Merged

aiordache merged 1 commit into docker:master from aiordache:fix_ssh_bug

Feb 9, 2021

Collaborator

aiordache commented Feb 8, 2021 •

edited by ulyssessouza

Several fixes:

correctly trim the 'ssh://' from context host.
pass parent's environment to the shellout process
remove '-q' ssh flag that hides possible errors
refactor ssh command args

Resolves docker/compose#8096

aiordache requested a review from ulyssessouza as a code owner

February 8, 2021 19:32


          Fix host trimming and remove quiet flag for the ssh connection

caab390

Signed-off-by: aiordache <anca.iordache@docker.com>

aiordache force-pushed the fix_ssh_bug branch from ccbb4ab to caab390 Compare

February 9, 2021 09:17

ulyssessouza approved these changes

View reviewed changes

aiordache merged commit d7b16ef into docker:master

aiordache added this to the 4.4.2 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment