Use DOCKER_CONFIG to have creds in dind environment #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanScherer
requested review from
aiordache and
ulyssessouza
as code owners
StefanScherer
force-pushed
the
clean-home-docker
branch
from
2bd2d6f
to
5e4792a
Compare
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
StefanScherer
force-pushed
the
clean-home-docker
branch
from
5e4792a
to
6de6936
Compare
Signed-off-by: aiordache <anca.iordache@docker.com>
aiordache
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to mount the docker creds into the dind environment, but Jenkins doesn't put it in
~/.docker/config.jsonon the host, but in$DOCKER_CONFIGenvironment variable. So use the variable instead to keep the machines in a sane state.We otherwise accidentally created a folder
~/.docker/config.json/which then breaks anywrappedNodeandwithDockerRegistrysteps.