Make python 3.6 the minimum version #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
force-pushed
the
set-minimal-python-to-3_6
branch
from
0b2db96
to
dbe1bd8
Compare
There was a problem hiding this comment.
Hi, @ulyssessouza. I made some comments.
Have a nice day :)
| @@ -1,11 +1,7 @@ | |||
| ARG PYTHON_VERSION=2.7 | |||
| ARG PYTHON_VERSION=3.7 | |||
There was a problem hiding this comment.
Shouldn't that be 3.6?
There was a problem hiding this comment.
For this one, it's the version on which it will be compiled. Doesn't have a relationship with the minimal version
| @@ -73,7 +70,7 @@ def runTests = { Map settings -> | |||
| throw new Exception("Need Docker version to test, e.g.: `runTests(dockerVersion: '19.03.12')`") | |||
| } | |||
| if (!pythonVersion) { | |||
| throw new Exception("Need Python version being tested, e.g.: `runTests(pythonVersion: 'py2.7')`") | |||
| throw new Exception("Need Python version being tested, e.g.: `runTests(pythonVersion: 'py3.7')`") | |||
There was a problem hiding this comment.
This one is the same as above. It's the version on which it will be tested. Not released.
tests/Dockerfile-dind-certs
Outdated
| @@ -1,4 +1,4 @@ | |||
| ARG PYTHON_VERSION=2.7 | |||
| ARG PYTHON_VERSION=3.7 | |||
gtardif
reviewed
Mar 19, 2021
ulyssessouza
force-pushed
the
set-minimal-python-to-3_6
branch
from
dbe1bd8
to
116ab9c
Compare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
set-minimal-python-to-3_6
branch
from
116ab9c
to
c8fba21
Compare
|
@gtardif For the CI question, I'm not sure from where it comes. That's maybe cached from previous build where it used to exist on github actions configuration. Since this PR removes it |
aiordache
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2767