limit upper bound of dependencies in setup.py and add six as explicit dependency #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelletier2017
force-pushed
the
websocket-client-dependency
branch
from
8cc39ab
to
31b9bb6
Compare
till
reviewed
May 19, 2021
Signed-off-by: Andrew Pelletier <pelletierra@gmail.com>
pelletier2017
force-pushed
the
websocket-client-dependency
branch
from
f54af15
to
bc4256e
Compare
pelletier2017
changed the title
|
Updated with input from @till about the other dependencies and added explicit dependency for six which is used in the project. |
JonZeolla
reviewed
Aug 13, 2021
| 'requests >= 2.14.2, != 2.18.0', | ||
| 'websocket-client >= 0.32.0, < 1', | ||
| 'requests >= 2.14.2, != 2.18.0, < 3', | ||
| 'six >= 1.16.0, < 2', |
There was a problem hiding this comment.
This should not be added here, this was resolved in a9748a8
There was a problem hiding this comment.
@JonZeolla what's the best way to get people's attention to PRs? 😅
|
We no longer use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency
websocket-clientrecently released version 1.0.0 which removedsixas a dependency. This breaks becausedocker/auth.pyusessixwithout adding it as a dependency insetup.py.Version
1.16.0ofsixis used because it was the only one I've tested it with but the lower bound could likely be lowered.This addresses #2840