Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Image.save documentation with a working example. Issue #836 #2851

Merged
merged 1 commit into from Jun 29, 2021
Merged

Update the Image.save documentation with a working example. Issue #836 #2851

merged 1 commit into from Jun 29, 2021

Conversation

huogerac
Copy link
Contributor

@huogerac huogerac commented Jun 3, 2021

The former save example doesn't work, so I updated it for one that works.

@huogerac
[DOCS] Update the Image.save documentation with a working example. Is…
d58ca97 
…sue docker#836

Signed-off-by: Roger Camargo <huogerac@gmail.com>
@huogerac huogerac mentioned this pull request Jun 26, 2021
Closed
@huogerac
Copy link
Contributor Author

Hi,
Is something wrong in the PR? Am I missing something, it's about a quick fix in the documentation, no code was changed.
It's to help others use the library using the documentation. Indeed, I have more example to add to the docker-py.readthedocs.io, however, I'm waiting for this PR to be accepted or not..
Cheers
Roger

mat007
mat007 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mat007 mat007 merged commit 650aad3 into docker:master Jun 29, 2021
@aiordache aiordache added this to the 5.0.1 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat007 mat007 mat007 approved these changes

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huogerac @mat007 @aiordache