Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pywin32 version in setup.py, update in requirements.txt #2943

Closed
wants to merge 2 commits into from
Closed

Bump pywin32 version in setup.py, update in requirements.txt #2943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47c397
Bump pywin32 version in setup.py, update in requirements.txt
Jan 24, 2022
019b84d
Bump pinned pywin32 to 301
Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ paramiko==2.8.0
pycparser==2.17
pyOpenSSL==18.0.0
pyparsing==2.2.0
pywin32==301; sys_platform == 'win32'
pywin32==303; sys_platform == 'win32'
requests==2.26.0
urllib3==1.26.5
websocket-client==0.56.0
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

extras_require = {
# win32 APIs if on Windows (required for npipe support)
':sys_platform == "win32"': 'pywin32==227',
':sys_platform == "win32"': 'pywin32>=227',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
':sys_platform == "win32"': 'pywin32>=227',
':sys_platform == "win32"': 'pywin32>=301',

maybe? to avoid GHSA-hwfp-hg2m-9vr2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I just updated that.


# If using docker-py over TLS, highly recommend this option is
# pip-installed or pinned.
Expand Down