fix: Missing comma in api_build_test.py
#2946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrshu
commented
Jan 29, 2022
mrshu
commented
- The comma has been most probably left out unintentionally, leading to string concatenation between the two consecutive lines. It has been found automatically using a regular expression.
* The comma has been most probably left out unintentionally, leading to string concatenation between the two consecutive lines. It has been found automatically using a regular expression.
|
@rumpl Should be done now 🙂 |
* The comma has been most probably left out unintentionally, leading to string concatenation between the two consecutive lines. It has been found automatically using a regular expression. Signed-off-by: mr.Shu <mr@shu.io>
|
Thanks for the fix! Unfortunately, one of the commits (ca702c5) is still missing the DCO. The instructions from the bot should explain how to rebase and add it. |
|
Feel free to re-open after updating with DCO if desired. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.