Change container's exec_run function to return tuple of (function that returns exit_code
, output) when stream/socket=True
#2963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by: #2557
As explained in issue above, getting the exit code might be needed even when running with
socket
orstream
set to True.This can be easily achieved by returning a function that returns that exit code.
A simple use case:
Note the above assumes (this behaviour was tested) that the exit code returned is None until the executed command/program finishes.
Signed-off-by: Tzah Mazuz tmazuz@nvidia.com