Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix a couple flaky/broken tests #3008

Merged
merged 2 commits into from Jul 26, 2022
Merged

test: fix a couple flaky/broken tests #3008

merged 2 commits into from Jul 26, 2022

Commits on Jul 26, 2022

  1. test: fix flaky container log test 

    Ensure the container has exited before attempting to grab the logs.

Since we are not streaming them, it's possible to attach + grab logs
before the output is processed, resulting in a test failure. If the
container has exited, it's guaranteed to have logged :)

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    74e0c5e View commit details
    Browse the repository at this point in the history

  2. test: mark invalid test as xfail 

    This test looks for some behavior on non-chunked HTTP requests.

It now fails because it looks like recent versions of Docker Engine
ALWAYS return chunked responses (or perhaps this specific response
changed somehow to now trigger chunking whereas it did not previously).

The actual logic it's trying to test is also unusual because it's
trying to hackily propagate errors under the assumption that it'd get
a non-chunked response on failure, which is...not reliable. Arguably,
the chunked reader should be refactored somehow but that's a refactor
we can't really commit to (and it's evidently been ok enough as is
up until now).

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
    @milas
    milas committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    4765f62 View commit details
    Browse the repository at this point in the history