Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: pin urllib3 version to < 2 #3114

Closed
wants to merge 1 commit into from
Closed

hotfix: pin urllib3 version to < 2 #3114

wants to merge 1 commit into from

Conversation

wadhah101
Copy link

Closes #3113

Urllib3 v2 have introduced some breaking changes. The easiest fix for now to pin the package to < 2.

Another issue for upgrading Urllib3 must be added.

@wadhah101 wadhah101 changed the title fix urllib v3 version <2 hotfix: pin urllib v3 version to < 2 Apr 28, 2023
@wadhah101 wadhah101 changed the title hotfix: pin urllib v3 version to < 2 hotfix: pin urllib3 version to < 2 Apr 28, 2023
rafaelgieschke referenced this pull request in emulation-as-a-service/eaas-installer Apr 30, 2023
@rafaelgieschke
fix: work around problems with urllib3 2.0
134c2bb 
urllib3 2.0 (<https://urllib3.readthedocs.io/en/stable/v2-migration-guide.html>) breaks
<ansible-collections/community.docker#611> via 
<docker/docker-py#3113>.
@felixfontein
Copy link
Contributor

You should also restrict requests < 2.29.0, since that also breaks parts of Docker SDK for Python. I've seen stacktraces with urllib3 < 2.0.0 and requests == 2.29.0 when using ContainerApiMixin.put_archive().

@wadhah101
Copy link
Author

@felixfontein Can you provide any examples ? The ci in my repo seems to be passing https://github.com/wadhah101/docker-py/pull/1
The only thing going with requests is psf/requests#6226 which should be ok when using urllib3 < 2

@felixfontein
Copy link
Contributor

@wadhah101 #3113 (comment)

@wadhah101
Copy link
Author

#3116 does a better job

@wadhah101 wadhah101 closed this May 5, 2023
@kuiber kuiber mentioned this pull request May 7, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urllib3 v2 incompatibility
2 participants
@wadhah101 @felixfontein